Refactor card handling, improve test coverage, and update package to v1.2.4#50
Merged
ioan-ghisoi-cko merged 3 commits intomainfrom Aug 13, 2025
Merged
Refactor card handling, improve test coverage, and update package to v1.2.4#50ioan-ghisoi-cko merged 3 commits intomainfrom
ioan-ghisoi-cko merged 3 commits intomainfrom
Conversation
Collaborator
ioan-ghisoi-cko
commented
Aug 13, 2025
ioan-ghisoi-cko
commented
- Enhanced CardNumber component for safer input handling and updated formatDataForTokenization to robustly manage potential null values in card number and expiry date.
- Added unit tests for card utilities and context guards; improved HTTP and logger test coverage; updated type definitions.
- Bumped package version to 1.2.4 in package.json.
…d logger tests, update types
… and clarity - Updated CardNumber component to ensure safe handling of card number input, replacing null values and using a sanitized digit string for validation. - Enhanced formatDataForTokenization function to handle potential null values for card number and expiry date, improving robustness in data formatting.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
===========================================
+ Coverage 68.83% 85.52% +16.68%
===========================================
Files 12 12
Lines 215 221 +6
Branches 62 68 +6
===========================================
+ Hits 148 189 +41
+ Misses 37 3 -34
+ Partials 30 29 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicolas-maalouf-cko
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.